Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(331) - Stylo edit should appear even when observation is a long text #332

Merged
merged 21 commits into from
Sep 16, 2024

Conversation

aleckvincent
Copy link
Collaborator

No description provided.

@aleckvincent aleckvincent self-assigned this Sep 9, 2024
@aleckvincent aleckvincent linked an issue Sep 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 9, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 77.84% (🎯 50%) 1813 / 2329
🟢 Statements 77.72% (🎯 50%) 1881 / 2420
🟢 Functions 75.2% (🎯 50%) 470 / 625
🟢 Branches 69.07% (🎯 50%) 764 / 1106
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/features/pam/mission/components/elements/timeline/item/timeline-item-status.tsx 100% 90% 100% 100%
Generated in workflow #1010

aleckvincent and others added 5 commits September 11, 2024 14:17
 - Create a common component action-dropdown with 2 menu items, main and sub
 - on click, show sub menu item
 - remove old component
 - test it

This comment was marked as resolved.

xtiannyeto and others added 15 commits September 16, 2024 10:52
 - use FormikEffect and Formik component
 - Add timer to delay mutation
 - Test eveything
 - new arborescence and fix test
 - Create hook with common behavior of control
 - Test hook
 - Refactor control administrative to use hook
 - Refactor control gens de mer to use hook
 - Test control gens de mer
  -  block init calls
 - Just test Have been called.
 - TODO: check number of called for later
 - default behavior, if data and unitHasConfirm null then set true
 - move common check into hook
 - test it
 - on security and navigation control use hook useControl
 - on security and navigation control Refactor form with formik and FormikEffect
 - On administrative and gensDeMer, remove control already in useControl hook
 - Add tests
 - Remove _ import, just methods
 - Update algorithm of nbrHourAtSea
 - Update tests around
 - Make sure that .last() is called on a not empty collection
 - override path-to-regexp to version 8
@aleckvincent aleckvincent merged commit 5765590 into main Sep 16, 2024
9 checks passed
@aleckvincent aleckvincent deleted the 331-stylo-edit-disparait-lorsque-phrase-trop-longue branch September 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

stylo “édité” disparaît lorsque phrase trop longue
3 participants